Add shared calendar invite to site #1642
Conversation
aj-stein-nist
added
the
Scope: Website
|
An alternate approach, and I already got some negative feedback from one of the trusted members of the team (and that's ok! 😆) is embedding the
|
|
Need to experiment more with some feedback I got.
|
aj-stein-nist
changed the title
aj-stein-nist
force-pushed
the
1408-add-calendar-feed-to-website
branch
from
77f27f1
to
0c801c7
Compare
|
NB: For portability I think it would be a good idea to break out the calendar into its own shortcode so that it can be embedded into multiple pages. That being said, premature optimization is the root of all evil and I might be suggesting this prematurely. |
I think that is actually a wonderful idea, but we might want to backlog that and cross-ref with hugo-uswds since we would want it to be maximally reusable, right? I believe that is where almost all of our shortcode logic currently resides for the portability concerns you have. That, or we can hoist it up later. Excellent point and thank you for the feedback, sir! |
|
Aaaand it seems like the Azure version of Ubuntu package manage repos as configured by GHA to use in GHA runners has some problems and it is breaking one of the unrelated builds. Will have to circle back to this anyway. |
Definitely ok with coming back to it, but as far as the hugo documentation suggests, you can define your own shortcodes outside of a theme in https://gohugo.io/templates/shortcode-templates/#shortcode-template-lookup-order There is no need to hoist this into the theme itself. |
There was a problem hiding this comment.
I checked both links on PC. It works on both: the browser and the Outlook. Someone should check it on Mac's Outlook to make sure that URL works.
We probably should add an explanation that ICS can be opened as new to be kept as a separate calendar to allow users not to merge the meetings into their calendars if they so desire or advise them to use the HTTP link to online outlook standalone calendar.
There was a problem hiding this comment.
I tested the functionality and it appears that the iCalendar works as designed. Since there are 2 approvals already, you do not need mine to move forward.
But I will not Approve the PR because it will imply I agree with flooding my calendar/ people's calendars with meetings I/they do not need and which I/they need to manually delete. We have now only Feb meetings on the events calendar. I need to also understand the envisioned operational process as we will keep adding events to the calendar. Will I grab in 3-4 months from now all past and future events through this .ics file? Will we refresh the .ics file every month to gather only the events of that month and every member of the community will have to manually go and grab the .ics file load all meetings and then clean the ones they do not need/want?
I addressed your individual point in the specific comment above: if people wish to look in the web, configure the dedicated calendar or both, they get to control what they see and how they see it, more than only emails that send only to their personal calendar, and each change must be reviewed and accepted so an integrated client (an email and calendar app that coordinate, Outlook is popular but not all work this way) properly send the update to their integrated calendar. If they do not, as has happened at least 33% of the time for two standing public meetings a month, at least one, sometimes two or more, are confused as they are today.
We have not defined a process, but I can envision we can come up with one in 15 minutes. That happens between #1638 and this PR. That is why this PR, in bold letters is addressed to the devs, but also specifically me, says verbatim:
Let us know if you have additional questions, comments, or concerns. |
I did read the note, and also reviewed the ADR. Please disregard my comments. The devs do not need any help testing it on a Mac laptop with MS Office client, Calendar, and Safari since there are two that have Macs. |
|
Added draft of SOP and integrated team feedback, can work on that out of band as AC met for this and dev work previously approved. https://github.com/usnistgov/OSCAL/wiki/Public-Events-Calendar-Management |
* Enhance website with link and embedded calendar. * Approach 1: set up cards and make the options clear. * Switch from lists to only `div`s, fix spacing. * Refactor close to PR feedback from Nikita.
Committer Notes
DO NOT MERGE before #1638 is approved and merged in.
Current design looks as of last commit like the screenshot below. Will update as the commit evolves.
If approved and merged, this closes #1408.
All Submissions:
"?~
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.